Compare commits

..
2 Commits
Author SHA1 Message Date
nelsbrock ebaf64982d fix documentation for tictactoe_game_check_streak 2025-03-20 20:44:56 +01:00
nelsbrock ac4d4eb4fa simplify parsing of coordinates 2025-03-20 20:35:03 +01:00
2 changed files with 8 additions and 8 deletions
+4 -3
View File
@@ -21,13 +21,14 @@ int tictactoe_game_init(ttt_game_t *game)
}
/*
* Steps over the board, starting from position (start_x, start_y) and ending
* Steps over the board, starting at position (start_x, start_y) and ending
* at the board's boundaries, checking if all cells are occupied by the same
* player.
*
* start_x and start_y must lie within the board's boundaries.
* start_x and start_y must be within the board's boundaries.
*
* Returns the respective player, or '\x00' if a cell isn't occupied.
* Returns the respective player, or '\x00' if no single player occupies all
* cells within the specified streak.
*/
static char tictactoe_game_check_streak(ttt_game_t *game, size_t start_x,
size_t start_y, ssize_t step_x,
+4 -5
View File
@@ -94,7 +94,7 @@ static ssize_t tictactoe_write(struct file *file, const char __user *buf,
{
char *command_buf;
size_t count_without_lf;
size_t human_x, human_y;
size_t x, y;
if (count == 0)
return 0;
@@ -145,8 +145,8 @@ static ssize_t tictactoe_write(struct file *file, const char __user *buf,
}
}
human_x = (size_t)(command_buf[0] - '0');
human_y = (size_t)(command_buf[1] - '0');
x = (size_t)(command_buf[0] - '1');
y = (size_t)(command_buf[1] - '1');
kfree(command_buf);
@@ -163,8 +163,7 @@ static ssize_t tictactoe_write(struct file *file, const char __user *buf,
#endif
}
if (tictactoe_game_make_turn(tictactoe_current_game, human_x - 1,
human_y - 1)) {
if (tictactoe_game_make_turn(tictactoe_current_game, x, y)) {
mutex_unlock(&tictactoe_mutex_current_game);
return -EINVAL;
}